Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set jsdom as default test environment #624

Merged
merged 2 commits into from
Aug 30, 2021
Merged

Conversation

mediremi
Copy link
Contributor

One of the new defaults in Jest 27 is the default test environment being node instead of jsdom.

This PR updates our default Jest config to set testEnvironment: 'jsdom'.

@mediremi mediremi requested a review from varl August 27, 2021 13:40
@mediremi
Copy link
Contributor Author

Thanks to this change I've been able to run d2-app-scripts test without any code changes in our apps.

@mediremi mediremi merged commit 2f1ba42 into beta Aug 30, 2021
@mediremi mediremi deleted the fix/jest-27-config branch August 30, 2021 08:15
dhis2-bot added a commit that referenced this pull request Aug 30, 2021
# [8.0.0-beta.2](v8.0.0-beta.1...v8.0.0-beta.2) (2021-08-30)

### Bug Fixes

* set jsdom as default test environment ([#624](#624)) ([2f1ba42](2f1ba42))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 8.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@varl varl mentioned this pull request Sep 8, 2021
dhis2-bot added a commit that referenced this pull request Sep 20, 2021
# [8.0.0](v7.6.6...v8.0.0) (2021-09-20)

### Bug Fixes

* **alerts-service:** add tests and align implementation ([dabe477](dabe477))
* **cli:** set test environment to node ([#625](#625)) ([36d311b](36d311b))
* **dependencies:** update app-runtime to v3 ([8777699](8777699))
* set jsdom as default test environment ([#624](#624)) ([2f1ba42](2f1ba42))

### chore

* **deps:** upgrade to 7.0.0 of @dhis2/ui ([b624c9e](b624c9e))
* **deps:** upgrade to styled-jsx 4.x ([8cf9e17](8cf9e17))

### Features

* **app-adapter:** align Alerts component with alerts-service and AlertBar ([bd4564c](bd4564c))
* **cli:** instance proxy server ([#635](#635)) ([9df387e](9df387e))
* bump jest to v27 ([f5015b2](f5015b2))

### BREAKING CHANGES

* **deps:** @dhis2/ui 7.x has dropped support for the deprecated
entrypoints @dhis2/ui-core and @dhis2/ui-widgets.
Please use @dhis2/ui to import components you need in your app.
Everything from core and widgets is available.
* **deps:** Upgrade to styled-jsx 4 requires that the application
uses a compatible version of @dhis2/ui.
* **dependencies:** This updates the app-platform to version 3 of the
app-runtime. That means that this version of the app-platform will only
work with apps that use version 3 of the app-runtime.
* Upgrade Jest to 27.x.
Please see for a list of changes: https://jestjs.io/blog/2021/05/25/jest-27
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants